Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto_link() converts invalid strings like ://codeigniter.com #9180

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix: auto_link() converts invalid strings like ://codeigniter.com #9180

merged 2 commits into from
Sep 13, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 8, 2024

Description
See #9165 (comment)

  • fix a bug that auto_link() converts invalid strings without a scheme like ://codeigniter.com

scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )
https://datatracker.ietf.org/doc/html/rfc3986#section-3.1

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 8, 2024
@kenjis kenjis mentioned this pull request Sep 8, 2024
Closed
@kenjis kenjis merged commit d49d700 into codeigniter4:develop Sep 13, 2024
41 checks passed
@kenjis kenjis deleted the fix-auto_link-bug branch September 13, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @ddevsr