Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #25

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Update README.md #25

merged 1 commit into from
Dec 17, 2021

Conversation

galihlasahido
Copy link
Contributor

typo in some service name (setting, suppose to be settings) resulting Call to a member function get() on null

typo in some service name (setting, suppose to be settings) resulting Call to a member function get() on null
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It is a little confusing since the helper function is singular, but the service and helper file are both plural.

@MGatner MGatner merged commit cf9ae1e into codeigniter4:develop Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants