Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring #40

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Small refactoring #40

merged 4 commits into from
Sep 22, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 21, 2022 •
edited
Loading

Needs to rebase after merging #39

  • add properties
  • add PHPDoc

MGatner
MGatner approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have already addressed my comment before it was made, yet again 🥳

@kenjis kenjis merged commit de0b7c4 into codeigniter4:develop Sep 22, 2022
@kenjis kenjis deleted the small-refactoring branch September 22, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @lonnieezell @MGatner