Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace empty() by rector #1081

Merged
merged 4 commits into from
Apr 5, 2024
Merged

refactor: replace empty() by rector #1081

merged 4 commits into from
Apr 5, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 5, 2024 •
edited
Loading

Description

  • update rector.php
  • refactor

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft April 5, 2024 01:19
@kenjis kenjis marked this pull request as ready for review April 5, 2024 02:10
@kenjis kenjis force-pushed the refactor-update-rector-config branch from 30e9b42 to f2571a9 Compare April 5, 2024 02:11
@kenjis kenjis changed the title refactor: by rector refactor: replace empty() by rector Apr 5, 2024
@datamweb datamweb added the refactor Pull requests that refactor code label Apr 5, 2024
datamweb
datamweb approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

@kenjis kenjis merged commit 7088333 into codeigniter4:develop Apr 5, 2024
37 checks passed
@kenjis kenjis deleted the refactor-update-rector-config branch April 5, 2024 23:30
@kenjis
Copy link
Member Author

kenjis commented Apr 5, 2024

Rector does a good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @paulbalandan