Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: passing Time to Query Builder in UserModel #1095

Merged
merged 1 commit into from
Apr 14, 2024
Merged

fix: passing Time to Query Builder in UserModel #1095

merged 1 commit into from
Apr 14, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 9, 2024 •
edited
Loading

Description
See #1086, #1092

Query Builder does not accept Time instances.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request Apr 9, 2024
Closed
@kenjis kenjis changed the title fix: passing Time to Query Builder fix: passing Time to Query Builder in UserModel Apr 9, 2024
@kenjis kenjis added the bug Something isn't working label Apr 9, 2024
@datamweb datamweb mentioned this pull request Apr 9, 2024
Closed
@kenjis kenjis merged commit 2ed8b33 into codeigniter4:develop Apr 14, 2024
37 checks passed
@kenjis kenjis deleted the fix-UserModel-updateActiveDate branch April 14, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @datamweb