Skip to content

fix: escape string to prevent XSS attack #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 22, 2024
Merged

fix: escape string to prevent XSS attack #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d98596c
escaping string for prevention of XSS attacks.
warcooft Jul 18, 2024
bcf9cd2
escaping string for prevention of XSS attacks.
warcooft Jul 18, 2024
1cc1752
escaping string for prevention of XSS attacks.
warcooft Jul 18, 2024
c0f0332
escaping string for prevention of XSS attacks.
warcooft Jul 18, 2024
fb895d9
escaping string for prevention of XSS attacks.
warcooft Jul 18, 2024
2424dee
update typo
warcooft Jul 19, 2024
9e283d3
update typo
warcooft Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Views/email_2fa_show.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<p><?= lang('Auth.confirmEmailAddress') ?></p>

<?php if (session('error')) : ?>
<div class="alert alert-danger"><?= session('error') ?></div>
<div class="alert alert-danger"><?= esc(session('error')) ?></div>
<?php endif ?>

<form action="<?= url_to('auth-action-handle') ?>" method="post">
Expand Down
2 changes: 1 addition & 1 deletion src/Views/email_2fa_verify.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<p><?= lang('Auth.emailConfirmCode') ?></p>

<?php if (session('error') !== null) : ?>
<div class="alert alert-danger"><?= session('error') ?></div>
<div class="alert alert-danger"><?= esc(session('error')) ?></div>
<?php endif ?>

<form action="<?= url_to('auth-action-verify') ?>" method="post">
Expand Down
2 changes: 1 addition & 1 deletion src/Views/email_activate_show.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<h5 class="card-title mb-5"><?= lang('Auth.emailActivateTitle') ?></h5>

<?php if (session('error')) : ?>
<div class="alert alert-danger"><?= session('error') ?></div>
<div class="alert alert-danger"><?= esc(session('error')) ?></div>
<?php endif ?>

<p><?= lang('Auth.emailActivateBody') ?></p>
Expand Down
8 changes: 4 additions & 4 deletions src/Views/login.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,22 @@
<h5 class="card-title mb-5"><?= lang('Auth.login') ?></h5>

<?php if (session('error') !== null) : ?>
<div class="alert alert-danger" role="alert"><?= session('error') ?></div>
<div class="alert alert-danger" role="alert"><?= esc(session('error')) ?></div>
<?php elseif (session('errors') !== null) : ?>
<div class="alert alert-danger" role="alert">
<?php if (is_array(session('errors'))) : ?>
<?php foreach (session('errors') as $error) : ?>
<?= $error ?>
<?= esc($error) ?>
<br>
<?php endforeach ?>
<?php else : ?>
<?= session('errors') ?>
<?= esc(session('errors')) ?>
<?php endif ?>
</div>
<?php endif ?>

<?php if (session('message') !== null) : ?>
<div class="alert alert-success" role="alert"><?= session('message') ?></div>
<div class="alert alert-success" role="alert"><?= esc(session('message')) ?></div>
<?php endif ?>

<form action="<?= url_to('login') ?>" method="post">
Expand Down
6 changes: 3 additions & 3 deletions src/Views/register.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@
<h5 class="card-title mb-5"><?= lang('Auth.register') ?></h5>

<?php if (session('error') !== null) : ?>
<div class="alert alert-danger" role="alert"><?= session('error') ?></div>
<div class="alert alert-danger" role="alert"><?= esc(session('error')) ?></div>
<?php elseif (session('errors') !== null) : ?>
<div class="alert alert-danger" role="alert">
<?php if (is_array(session('errors'))) : ?>
<?php foreach (session('errors') as $error) : ?>
<?= $error ?>
<?= esc($error) ?>
<br>
<?php endforeach ?>
<?php else : ?>
<?= session('errors') ?>
<?= esc(session('errors')) ?>
<?php endif ?>
</div>
<?php endif ?>
Expand Down