Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add german translation #321

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Add german translation #321

merged 4 commits into from
Aug 2, 2022

Conversation

sba
Copy link
Contributor

@sba sba commented Jul 27, 2022 •
edited
Loading

For German-speaking people: In der Übersetzung sieze ich den Benutzer. Wäre duzen besser? Oder ohne direkte Anrede, also im Sinn von "Bitte E-Mail Adresse bestätigen" anstelle von "Bestätigen Sie Ihre E-Mail Adresse" oder "Bestätige deine E-Mail Adresse'?

@sba
Add german translation
df09ccc 
For German-speaking people: In der Übersetzung sieze ich den Benutzer. Wäre duzen besser? Oder ohne direkte Anrede, also im Sinn von "Bitte E-Mail Adresse bestätigen" anstelle von "Bestätigen Sie Ihre E-Mail Adresse" oder "Bestätigen deine E-Mail Adresse'
@datamweb
Copy link
Collaborator

Hallo @sba ,
Thank you for contributing!
Please add test code.
See #235 (comment)

@sba
Copy link
Contributor Author

sba commented Jul 27, 2022

Please add test code.

ok, I added the test-file: #322

@datamweb
Copy link
Collaborator

One thing at a time: a pull request should only contain one change. That does not mean only one commit, but one change - however many commits it took. The reason for this is that if you change X and Y but send a single pull request for both at the same time, we might really want X but disagree with Y, meaning we cannot merge the request. Using the Git-Flow branching model you can create new branches for both of these features and send two requests.
more info see

@kenjis kenjis mentioned this pull request Jul 27, 2022
Closed
@sba
Copy link
Contributor Author

sba commented Jul 28, 2022 •
edited
Loading

@datamweb thanks for your comment - I added the test changes to this commit, I hope it's ok now.

@kenjis
Copy link
Member

kenjis commented Jul 28, 2022

@sba
Please fix the coding style.
Run composer cs-fix.

See https://github.com/codeigniter4/shield/runs/7555124912?check_suite_focus=true

@sba
Code Style
5f49058 
fixed with 
```composer cs-fix```
MGatner
MGatner approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Danke

kenjis
kenjis approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis merged commit 7855d91 into codeigniter4:develop Aug 2, 2022
@kenjis kenjis added the lang Languages file label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
lang Languages file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sba @datamweb @kenjis @MGatner