Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic link add link back to login #394

Closed
wants to merge 2 commits into from
Closed

Magic link add link back to login #394

wants to merge 2 commits into from

Conversation

jlopes90
Copy link
Contributor

Supersedes #375

@datamweb datamweb added enhancement New feature or request tests needed Pull requests that need tests labels Aug 19, 2022
@kenjis
Copy link
Member

kenjis commented Aug 24, 2022

Note, we expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests are not accompanied by relevant tests, they will likely be closed.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#contributions

If you are not familiar with PHPUnit testing, See Resources

@datamweb datamweb added the GPG-Signing needed Pull requests that need GPG-Signing label Sep 17, 2022
@datamweb datamweb added the stale Pull requests with conflicts label Apr 22, 2023
@datamweb datamweb mentioned this pull request May 7, 2023
Merged
@jlopes90 jlopes90 closed this May 17, 2023
@jlopes90 jlopes90 deleted the magic-link-add-link-back-to-login branch May 17, 2023 08:46
@datamweb
Copy link
Collaborator

@jlopes90 Thank you very much for your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request GPG-Signing needed Pull requests that need GPG-Signing stale Pull requests with conflicts tests needed Pull requests that need tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlopes90 @kenjis @datamweb