Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MkDocs Documentation #513

Merged
merged 2 commits into from
Nov 9, 2022
Merged

MkDocs Documentation #513

merged 2 commits into from
Nov 9, 2022

Conversation

activivan
Copy link
Contributor

@activivan activivan commented Nov 7, 2022

Supersedes #508 and #21

After struggling with signing my old commits, this is the new pull request for the MkDocs Documentation
https://squidfunk.github.io/mkdocs-material/

@datamweb datamweb added GPG-Signing needed Pull requests that need GPG-Signing and removed GPG-Signing needed Pull requests that need GPG-Signing labels Nov 8, 2022
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for @kenjis to confirm before applying.

.github/workflows/docs.yml Show resolved Hide resolved
@kenjis kenjis added the documentation Improvements or additions to documentation label Nov 8, 2022
.gitignore Show resolved Hide resolved
@datamweb
Copy link
Collaborator

datamweb commented Nov 8, 2022

Can you fix this issue?

Screenshot 2022-11-08 092647

@activivan
Copy link
Contributor Author

This seems to have fixed it

@datamweb
Copy link
Collaborator

datamweb commented Nov 8, 2022

This seems to have fixed it

Thanks, LGTM!

@kenjis
Copy link
Member

kenjis commented Nov 8, 2022

$ pip3 install mkdocs
$ pip3 install mkdocs-material
$ mkdocs --version
mkdocs, version 1.4.2 from /usr/local/lib/python3.10/site-packages/mkdocs (Python 3.10)
$ mkdocs build
$ mkdocs serve

Screenshot 2022-11-09 8 09 01

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Very cool to have, thanks @activivan

@datamweb datamweb merged commit 4dc315b into codeigniter4:develop Nov 9, 2022
@datamweb
Copy link
Collaborator

datamweb commented Nov 9, 2022

@activivan Thanks for this PR.

@lonnieezell Please check here, if possible, create a subdomain.

@kenjis
Copy link
Member

kenjis commented Nov 10, 2022

Something wrong with GitHub Pages:
https://kenjis.github.io/codeigniter-shield/

$ mkdocs gh-deploy --force
INFO     -  Cleaning site directory
INFO     -  Building documentation to directory: /Users/kenji/work/codeigniter/official/codeigniter-shield/site
INFO     -  Documentation built in 1.10 seconds
WARNING  -  Version check skipped: No version specified in previous deployment.
INFO     -  Copying '/Users/kenji/work/codeigniter/official/codeigniter-shield/site' to 'gh-pages' branch and
            pushing to GitHub.
Enumerating objects: 81, done.
Counting objects: 100% (81/81), done.
Delta compression using up to 4 threads
Compressing objects: 100% (65/65), done.
Writing objects: 100% (81/81), 532.13 KiB | 2.21 MiB/s, done.
Total 81 (delta 15), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (15/15), done.
remote: 
remote: Create a pull request for 'gh-pages' on GitHub by visiting:
remote:      https://github.com/kenjis/codeigniter-shield/pull/new/gh-pages
remote: 
To github.com:kenjis/codeigniter-shield.git
 * [new branch]      gh-pages -> gh-pages
INFO     -  Your documentation should shortly be available at: https://kenjis.github.io/codeigniter-shield/

@kenjis
Copy link
Member

kenjis commented Nov 10, 2022

I pushed gh-pages branch.

$ mkdocs gh-deploy --force
INFO     -  Cleaning site directory
INFO     -  Building documentation to directory: /Users/kenji/work/codeigniter/tmp/shield/site
INFO     -  Documentation built in 0.71 seconds
WARNING  -  Version check skipped: No version specified in previous deployment.
INFO     -  Copying '/Users/kenji/work/codeigniter/tmp/shield/site' to 'gh-pages' branch and pushing to GitHub.
Enumerating objects: 81, done.
Counting objects: 100% (81/81), done.
Delta compression using up to 4 threads
Compressing objects: 100% (65/65), done.
Writing objects: 100% (81/81), 532.13 KiB | 2.60 MiB/s, done.
Total 81 (delta 15), reused 3 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (15/15), done.
remote: 
remote: Create a pull request for 'gh-pages' on GitHub by visiting:
remote:      https://github.com/codeigniter4/shield/pull/new/gh-pages
remote: 
To github.com:codeigniter4/shield.git
 * [new branch]      gh-pages -> gh-pages
INFO     -  Your documentation should shortly be available at: https://codeigniter4.github.io/shield/

@kenjis
Copy link
Member

kenjis commented Nov 10, 2022

I set the GitHub Pages branch.
Okay, no problem.
https://codeigniter4.github.io/shield/

@datamweb
Copy link
Collaborator

Thanks❤️
Screenshot_2022-11-10-04-03-59-439_com android chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants