-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updateActiveDate query builder #520
Conversation
Sorry, what's the point? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method does a lot more bootstrapping than just accessing the property. It also isn't final
so it is possible someone is extending it for additional behavior.
I'm good with this change.
Hello, See : |
And improving the commit message is welcome.
|
f188c37
to
3e49082
Compare
Please pay attention to what Kenjis said. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit messages are important. They communicate the intent of a specific change, concisely. They make it easier to review code, and to find out why a change was made if the code history is examined later.
The audience for your commit messages will be the codebase maintainers, any code reviewers, and debuggers trying to figure out when a bug might have been introduced.
Make your commit messages meaningful.
Commit messages are expected to be descriptive of why and what you changed specifically. Commit messages like "Fixes #1234" would be asked by the reviewer to be revised.
3e49082
to
6aed867
Compare
@kenjis Waiting on you |
Thank you all. |
No description provided.