Skip to content

Update UserModelGenerator for CI 4.3.0 #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenjis merged 5 commits into from
Jan 12, 2023
Merged

Update UserModelGenerator for CI 4.3.0 #595

kenjis merged 5 commits into from
Jan 12, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jan 11, 2023 •
edited
Loading

See #596

  • update UserModelGenerator::run()
  • update tests

@kenjis kenjis force-pushed the update-UserModelGenerator-for-CI4.3.0 branch from df490d1 to dce2a12 Compare January 11, 2023 04:52
@kenjis kenjis mentioned this pull request Jan 11, 2023
Merged
@kenjis
Copy link
Member Author

kenjis commented Jan 11, 2023

Some checks failed, but they will be fixed in the next PR #597

datamweb
datamweb reviewed Jan 11, 2023
View reviewed changes
paulbalandan
paulbalandan reviewed Jan 12, 2023
View reviewed changes
paulbalandan
paulbalandan reviewed Jan 12, 2023
View reviewed changes
tests/Commands/UserModelGeneratorTest.php Outdated
parent::setUp();

CITestStreamFilter::$buffer = '';
// @phpstan-ignore-next-line
Copy link
Member

@paulbalandan paulbalandan Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be added to phpstan's dynamic constants.

Copy link
Member Author

@kenjis kenjis Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It is better! Done.

datamweb
datamweb approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis kenjis merged commit 11c1781 into codeigniter4:develop Jan 12, 2023
@kenjis kenjis deleted the update-UserModelGenerator-for-CI4.3.0 branch January 12, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @paulbalandan