feat: customize name of Shield Tables w/o constant #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kenjis merged 24 commits into codeigniter4:develop from kenjis:feat-rename-table-names-wo-constant

Feb 13, 2023

Member

kenjis commented Feb 10, 2023 •

edited by datamweb

Loading

Ref #628 (comment)
Supersedes #628

kenjis mentioned this pull request

feat: customize name of Shield Tables #628

Closed

kenjis force-pushed the feat-rename-table-names-wo-constant branch from 60c3554 to a0426ab Compare

February 10, 2023 00:15

Collaborator

datamweb commented Feb 10, 2023

Please update the branch, we have recently made changes:
https://github.com/codeigniter4/shield/pull/629/files#diff-72d57325d612cc25a56eec53a2f8c721d8ef92fd14b20e2f83446f226972f715R476

datamweb reviewed

View reviewed changes

src/Models/UserModel.php Outdated Show resolved Hide resolved

datamweb and others added 19 commits

February 11, 2023 10:07


          feat: add $authTables for customize shield table names

530a33c


          add: include Constants.php file for load

75136b5


          add: Constants.php file for easy access in all files.

aaaf255


          replace users with SHIELD_TABLES['users']

f6129f3


          replaced auth_identities with SHIELD_TABLES['auth_identities']

df26dde


          replaced auth_logins with SHIELD_TABLES['auth_logins']

44136b2


          replaced auth_token_logins with SHIELD_TABLES['auth_token_logins']

94f06ed


          replaced auth_remember_tokens with `SHIELD_TABLES['auth_remember_to…

60476e5

…kens']`


          replaced auth_groups_users with SHIELD_TABLES['auth_groups_users']

e261da3


          replaced auth_permissions_users with `SHIELD_TABLES['auth_permissio…

6d836c7

…ns_users']`


          fix: rector error

7fef82e


          style: run cs-fix

433f196


          rename $authTables to $tables and delete auth_ from array keys

6ed08e7


          delete auth_ from $tables keys

eafae2c


          fix: use new() for pass phpstan error

4faff62


          refactor: remove SHIELD_TABLES

c65c6b5


          refactor: extract BaseModel

1adcb5c


          refactor: remove $this->tableIdentities

b63c27f


          test: replace hard coded table names

2d93da1

kenjis force-pushed the feat-rename-table-names-wo-constant branch from 6ef79c6 to 2d93da1 Compare

February 11, 2023 01:14


          refactor: use CheckQueryReturnTrait in BaseModel

1bdd37c

datamweb reviewed

View reviewed changes

docs/customization.md Outdated Show resolved Hide resolved

datamweb reviewed

View reviewed changes

docs/customization.md Outdated Show resolved Hide resolved

datamweb reviewed

View reviewed changes

docs/customization.md Outdated Show resolved Hide resolved

datamweb reviewed

View reviewed changes

docs/customization.md Outdated Show resolved Hide resolved

datamweb reviewed

View reviewed changes

rector.php Outdated Show resolved Hide resolved

datamweb reviewed

View reviewed changes

src/Models/GroupModel.php Show resolved Hide resolved

datamweb reviewed

View reviewed changes

src/Models/LoginModel.php Show resolved Hide resolved

datamweb reviewed

View reviewed changes

src/Models/PermissionModel.php Show resolved Hide resolved

datamweb reviewed

View reviewed changes

src/Models/RememberModel.php Show resolved Hide resolved

datamweb reviewed

View reviewed changes

src/Models/TokenLoginModel.php Show resolved Hide resolved

datamweb reviewed

View reviewed changes

src/Models/UserIdentityModel.php Show resolved Hide resolved

kenjis added 2 commits

February 13, 2023 14:59


          docs: update Registration Validation Rules

343cfc1


          chore: remove deleted file setting

0aa37da

kenjis force-pushed the feat-rename-table-names-wo-constant branch from 5162280 to 0aa37da Compare

February 13, 2023 05:59

kenjis added 2 commits

February 13, 2023 15:17


          docs: add Custom Table Names

6a4d781


          docs: add note for tablename customization

1e67351

kenjis added the enhancement label

Member Author

kenjis commented Feb 13, 2023

Added docs.

datamweb approved these changes

View reviewed changes

Collaborator

datamweb left a comment

LGTM!
thanks!

kenjis merged commit 6197194 into codeigniter4:develop

kenjis deleted the feat-rename-table-names-wo-constant branch

February 13, 2023 23:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels