Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: update sk translation #665

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

jozefrebjak
Copy link
Contributor

No description provided.

@kenjis kenjis added the lang Languages file label Mar 12, 2023
@datamweb
Copy link
Collaborator

1) Tests\Authentication\Authenticators\AccessTokenAuthenticatorTest::testCheckOldToken
Failed asserting that true is false.

/home/runner/work/shield/shield/tests/Authentication/Authenticators/AccessTokenAuthenticatorTest.php:136
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:[60](https://github.com/codeigniter4/shield/actions/runs/4396498069/jobs/7700037263#step:11:61)

FAILURES!
Tests: 245, Assertions: 636, Failures: 1.

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis
Copy link
Member

kenjis commented Mar 12, 2023

PHPUnit / PHP 7.4 - MySQLi - lowest (pull_request) failed.
Why?

It seems because of Daylight Saving Time.

12 Mar 2023 - Daylight Saving Time Started
https://www.timeanddate.com/time/change/usa/chicago

--- a/src/Authentication/Authenticators/AccessTokens.php
+++ b/src/Authentication/Authenticators/AccessTokens.php
@@ -126,6 +126,11 @@ public function check(array $credentials): Result
 
         assert($token->last_used_at instanceof Time || $token->last_used_at === null);
 
+        dd(
+            (string) $token->last_used_at,
+            (string) Time::now()->subSeconds(config('Auth')->unusedTokenLifetime)
+        );
+
         // Hasn't been used in a long time
         if (
             $token->last_used_at
┌──────────────────────────────────────────────────────────────────────────────┐
│ (string) $token->last_used_at                                                │
└──────────────────────────────────────────────────────────────────────────────┘
string (19) "2022-03-12 19:27:23"
┌──────────────────────────────────────────────────────────────────────────────┐
│ (string) Time::now()->subSeconds(...)                                        │
└──────────────────────────────────────────────────────────────────────────────┘
string (19) "2022-03-12 18:28:23"
════════════════════════════════════════════════════════════════════════════════
Called from <ROOT>/src/Authentication/Authenticators/AccessTokens.php:131 [dd()]

@kenjis kenjis merged commit ff2a473 into codeigniter4:develop Mar 14, 2023
@kenjis
Copy link
Member

kenjis commented Mar 14, 2023

@jozefrebjak Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang Languages file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants