Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update phpstan-codeigniter to v1.3 #840

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

paulbalandan
Copy link
Member

Description
v1.3.0.70400 offers shiny new features

* Provides precise return types for `CodeIgniter\Model`'s `find()`, `findAll()`, and `first()` methods.
* Allows dynamic return type transformation of `CodeIgniter\Model` when `asArray()` or `asObject()` is called.

The new errors added is the result of phpstan not able to infer when names of selected fields are renamed, e.g. select('secret1 as email')

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis merged commit 424b2cb into codeigniter4:develop Sep 19, 2023
29 checks passed
@kenjis
Copy link
Member

kenjis commented Sep 19, 2023

@paulbalandan Thank you!

@paulbalandan paulbalandan deleted the update-phpstan-codeigniter branch September 19, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants