Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [HMAC Auth] wrong header key #844

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: [HMAC Auth] wrong header key #844

merged 1 commit into from
Sep 19, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 19, 2023

Description
Follow-up #795

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Something isn't working label Sep 19, 2023
@kenjis
Copy link
Member Author

kenjis commented Sep 19, 2023

@tswagger Review, please.

tswagger
tswagger approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@tswagger tswagger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good catch. Looks good to me.

@kenjis kenjis merged commit a331260 into codeigniter4:develop Sep 19, 2023
31 checks passed
@kenjis kenjis deleted the fix-hmac-loggedIn branch September 19, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@tswagger tswagger tswagger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @tswagger @datamweb