Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reorganize (part 3/3) #847

Merged
merged 6 commits into from
Sep 23, 2023
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 22, 2023

Description
See #841

  • split Authentication page
  • move "Session Authenticator Event and Logging" in "Session Authenticator"
  • add links to References

Screenshot 2023-09-22 17 54 46

Online Demo : https://datamweb.github.io/shield/

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Improvements or additions to documentation label Sep 22, 2023
datamweb
datamweb previously approved these changes Sep 22, 2023
@datamweb datamweb dismissed their stale review September 22, 2023 13:34

Need to add a copy button.

@datamweb
Copy link
Collaborator

datamweb commented Sep 22, 2023

@kenjis, if you can, please proceed as follows:

features:
  - navigation.sections
+ - content.code.copy

Screenshot 2023-09-22 170958

@kenjis
Copy link
Member Author

kenjis commented Sep 22, 2023

Added content.code.copy.

@kenjis kenjis mentioned this pull request Sep 23, 2023
5 tasks
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@datamweb datamweb merged commit dda86eb into codeigniter4:develop Sep 23, 2023
1 check passed
@datamweb
Copy link
Collaborator

@kenjis Can you create a subdomain as below so that documents are available with the subdomain.
https://shield.codeigniter.com/

Demo https://www.shield-oauth.codeigniter4.ir/

@kenjis kenjis deleted the docs-reorganize-3 branch September 23, 2023 20:20
@kenjis
Copy link
Member Author

kenjis commented Sep 23, 2023

No, I can't.
@lonnieezell @MGatner ?

@datamweb
Copy link
Collaborator

Guys, if you did, please don't forget to register a CNAME (codeigniter4.github.io) for the subdomain.

@MGatner
Copy link
Member

MGatner commented Sep 27, 2023

I will look into it - got a fair amount of website work that needs doing on there first.

@kenjis
Copy link
Member Author

kenjis commented Sep 27, 2023

Yes, updating the official website is a top priority.
codeigniter4projects/website#396 (comment)

@MGatner
Copy link
Member

MGatner commented Sep 28, 2023

The website looks like it is updated correctly. I got my key fixed and there are a lot of updates we should run on the box soon, but I will wait and coordinate with @lonnieezell

@kenjis kenjis added the enhancement New feature or request label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants