Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better website for docs #855

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Sep 25, 2023

Description

https://datamweb.github.io/shield/

Screenshot 2023-09-25 123843

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@datamweb datamweb merged commit ccb0dc1 into codeigniter4:develop Sep 25, 2023
1 check passed
@datamweb datamweb deleted the add-feat-site branch September 25, 2023 09:13
@kenjis
Copy link
Member

kenjis commented Sep 25, 2023

Ah, there some code that I can't see well in the dark mode.
Screenshot 2023-09-25 18 12 50

@datamweb
Copy link
Collaborator Author

Thank you, I will try to fix it in the new PR.

@kenjis
Copy link
Member

kenjis commented Sep 25, 2023

To be honest, the purple strings seem to be a bit too dark, too.
But this is better than above.
Screenshot 2023-09-25 18 20 12

@datamweb
Copy link
Collaborator Author

Screenshot 2023-09-25 152553

@kenjis if you can please check.
Let me know if it needs to be changed.

https://datamweb.github.io/shield/customization/redirect_urls/?h=loginredirect#customize-login-redirect

@kenjis
Copy link
Member

kenjis commented Sep 25, 2023

@datamweb Thank you! It is very easy to read!

@kenjis kenjis added the enhancement New feature or request label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants