Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Composer autoloading of auth helper #893

Merged
merged 8 commits into from
Oct 15, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 10, 2023

Description
See https://forum.codeigniter.com/showthread.php?tid=88545 and #872

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code labels Oct 10, 2023
@kenjis kenjis force-pushed the remove-autoload-auth_helper branch from 56ae492 to 4667548 Compare October 10, 2023 02:31
@kenjis kenjis force-pushed the remove-autoload-auth_helper branch from 4667548 to 0e93a57 Compare October 11, 2023 00:28
@datamweb
Copy link
Collaborator

src/Commands/Setup.php Outdated Show resolved Hide resolved
@kenjis kenjis force-pushed the remove-autoload-auth_helper branch from 0e93a57 to d2ea9d3 Compare October 12, 2023 00:13
@datamweb
Copy link
Collaborator

datamweb commented Oct 12, 2023

@kenjis we have used helper('setting'); in several places, can you remove?

Do we need this?

protected $helpers = ['setting'];

@kenjis
Copy link
Member Author

kenjis commented Oct 12, 2023

Testing with OCI8 always fails, but I don't know why.

Run echo -e "ALTER SESSION SET CONTAINER = XEPDB1;\nCREATE BIGFILE TABLESPACE \"TEST\" DATAFILE '/opt/oracle/product/18c/dbhomeXE/dbs/TEST' SIZE 10M AUTOEXTEND ON MAXSIZE UNLIMITED SEGMENT SPACE MANAGEMENT AUTO EXTENT MANAGEMENT LOCAL AUTOALLOCATE;\nCREATE USER \"ORACLE\" IDENTIFIED BY \"ORACLE\" DEFAULT TABLESPACE \"TEST\" TEMPORARY TABLESPACE TEMP QUOTA UNLIMITED ON \"TEST\";\nGRANT CONNECT,RESOURCE TO \"ORACLE\";\nexit;" | /lib/oracle/18.5/client64/bin/sqlplus -s sys/Oracle18@localhost:1521/XE as sysdba
ERROR:
ORA-12514: TNS:listener does not currently know of service requested in connect
descriptor


SP2-0306: Invalid option.
Usage: CONN[ECT] [{logon|/|proxy} [AS {SYSDBA|SYSOPER|SYSASM|SYSBACKUP|SYSDG|SYSKM|SYSRAC}] [edition=value]]
where <logon> ::= <username>[/<password>][@<connect_identifier>]
      <proxy> ::= <proxyuser>[<username>][/<password>][@<connect_identifier>]
SP2-0306: Invalid option.
Usage: CONN[ECT] [{logon|/|proxy} [AS {SYSDBA|SYSOPER|SYSASM|SYSBACKUP|SYSDG|SYSKM|SYSRAC}] [edition=value]]
where <logon> ::= <username>[/<password>][@<connect_identifier>]
      <proxy> ::= <proxyuser>[<username>][/<password>][@<connect_identifier>]
SP2-0157: unable to CONNECT to ORACLE after 3 attempts, exiting SQL*Plus
Error: Process completed with exit code 1.

https://github.com/codeigniter4/shield/actions/runs/6489501416/job/17623872761?pr=893

@kenjis
Copy link
Member Author

kenjis commented Oct 12, 2023

Removed helper('setting').

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@datamweb
Copy link
Collaborator

Testing with OCI8 always fails, but I don't know why.

This issue is not related to this PR.
Below test failure was observed even before this PR.

https://github.com/datamweb/shield/actions/runs/6498102065/job/17648716049

@kenjis kenjis force-pushed the remove-autoload-auth_helper branch 2 times, most recently from abf7dec to dbd6f5c Compare October 12, 2023 21:52
@datamweb datamweb closed this Oct 12, 2023
@datamweb datamweb reopened this Oct 12, 2023
@datamweb
Copy link
Collaborator

All checks have passed!

@kenjis kenjis merged commit 7774592 into codeigniter4:develop Oct 15, 2023
76 of 90 checks passed
@kenjis kenjis deleted the remove-autoload-auth_helper branch October 15, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants