Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update Config\Registrar #901

Merged
merged 2 commits into from
Oct 13, 2023
Merged

test: update Config\Registrar #901

merged 2 commits into from
Oct 13, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 12, 2023

Description

  • update DBDebug values
  • refactor

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Oct 12, 2023
@datamweb datamweb added the stale Pull requests with conflicts label Oct 12, 2023
@kenjis kenjis changed the title test: update Config\registrar test: update Config\Registrar Oct 13, 2023
@kenjis kenjis force-pushed the update-tests-Config-Registrar branch 2 times, most recently from 3705f6d to 038964c Compare October 13, 2023 02:24
@kenjis kenjis force-pushed the update-tests-Config-Registrar branch from 038964c to 5676a07 Compare October 13, 2023 02:25
@kenjis kenjis removed the stale Pull requests with conflicts label Oct 13, 2023
@datamweb datamweb closed this Oct 13, 2023
@datamweb datamweb reopened this Oct 13, 2023
datamweb
datamweb approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 8102411 into codeigniter4:develop Oct 13, 2023
56 of 61 checks passed
@kenjis kenjis deleted the update-tests-Config-Registrar branch October 13, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @datamweb