Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: [tr]&[uk] fix Invalid param in errorPasswordPwned #954

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Nov 19, 2023

Description
ref: #953

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added the lang Languages file label Nov 19, 2023
@datamweb
Copy link
Collaborator Author

datamweb commented Nov 19, 2023

@paulbalandan If you can check this topic and add it to Language Unit Test, it will be great.

@paulbalandan
Copy link
Member

I'm sorry I don't get what you mean. What do you want me to do?

@datamweb
Copy link
Collaborator Author

This is the original text:

'errorPasswordPwned' => 'The password {0} has been exposed due to a data breach and has been seen {1, number} times in {2} of compromised passwords.',

This text has been translated into another language, unfortunately number ({1, number}) have been translated in this field, which causes failure.

'errorPasswordPwned' => '{0} şifresi, bir veri ihlali nedeniyle açığa çıktı ve güvenliği ihlal edilmiş şifrelerin {2} tanesinde {1, sayı} kez görüldü.',

In fact, we did not realize this during the merger. Now I want to see if you can check by Language Unit Test that strings like (({1, number})) should not be translated.

@kenjis
Copy link
Member

kenjis commented Nov 19, 2023

Ref https://codeigniter4.github.io/CodeIgniter4/outgoing/localization.html#replacing-parameters

@datamweb datamweb merged commit fb4142b into codeigniter4:develop Nov 19, 2023
36 checks passed
@datamweb datamweb deleted the lang-fix-param branch November 19, 2023 21:32
@paulbalandan
Copy link
Member

Ok, I get it. I'll check what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang Languages file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants