Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
jyh0521
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
라우터 적용해주신거 좋네요! 사용하시지 않는 주석은 지워주셔도 좋습니다.
|
|
||
| try { | ||
| const response = await fetch( | ||
| `https://panda-market-api.vercel.app/products?${query}` |
There was a problem hiding this comment.
base url 부분은 보안상 외부로 노출하지 않는 것이 좋기 때문에 .env 파일을 만들어서 관리해주시고 gitignore에 .env를 올려주셔서 깃에 올라오지 않게 해주시는 것도 좋습니다.
| import React, { useState, useEffect } from "react"; | ||
| import { Link } from "react-router-dom"; | ||
| import ItemCard from "./ItemCard"; | ||
| import { getProducts as getAllItems } from "../../../js/itemApi"; |
There was a problem hiding this comment.
alias path라는 것을 적용해보시면 경로를 좀 더 깔끔하게 관리할 수 있습니다.
|
|
||
| // 화면 크기 변경 시, pageSize 재계산 | ||
| window.addEventListener("resize", handleResize); | ||
| fetchData({ page, pageSize, orderBy: "recent" }); |
There was a problem hiding this comment.
recent 같이 변하지 않는 값은 상수로 관리해주시면 좋습니다!
There was a problem hiding this comment.
컴포넌트는 내부에서 export와 return 해주셔야 합니다. 여기에는 둘 다 빠져있는 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크리스트 [기본]
중고마켓
중고마켓 반응형
베스트 상품
전체 상품
체크리스트 [심화]