Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Jul 8, 2024
Comment on lines
+53
to
+59
| Button.propTypes = { | ||
| size: PropTypes.oneOf(["small", "medium", "large"]).isRequired, | ||
| height: PropTypes.oneOf(["42", "48"]), | ||
| theme: PropTypes.oneOf(["blue", "white"]), | ||
| innerText: PropTypes.string, | ||
| to: PropTypes.string, | ||
| }; |
| @@ -1,6 +1,6 @@ | |||
| .searchBar { | |||
| display: flex; | |||
| background-color: #f3f4f6; | |||
| background-color: var(--gray100); | |||
| @@ -29,19 +31,45 @@ function AddItemPage() { | |||
| }); | |||
| }; | |||
|
|
|||
| const handleImageDelete = (e) => { | |||
| // 이미지 삭제 버튼 클릭 시, | |||
There was a problem hiding this comment.
함수명을 구체적으로 잘 작성해주셔서 주석은 달아주시지 않아도 어떤 역할을 하는 함수인지 잘 알아볼 수 있을 것 같습니다.
Comment on lines
+13
to
+14
| const ORDER_BY_RECENT = "recent"; | ||
| const ORDER_BY_FAVORITE = "favorite"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크리스트 [기본]
상품 상세
=> favoriteCount : 하트 개수
=> images : 상품 이미지
=> tags : 상품태그
=> name : 상품 이름
=> description : 상품 설명
상품 문의 댓글
=> image : 작성자 이미지
=> nickname : 작성자 닉네임
=> content : 작성자가 남긴 문구
=> description : 상품 설명
=> updatedAt : 문의글 마지막 업데이트 시간
멘토님께