Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgns2223
reviewed
Aug 26, 2024
Comment on lines
+23
to
+33
| axiosInstance.interceptors.response.use( | ||
| (response) => response, | ||
| (error) => { | ||
| if (axios.isAxiosError(error)) { | ||
| console.error("Error Messages: ", error.response?.data || error.message); | ||
| } else { | ||
| console.error("Error Messages: ", error); | ||
| } | ||
| return Promise.reject(error); | ||
| } | ||
| ); |
There was a problem hiding this comment.
response는 정의 하실 필요가 없을 것 같아요.
로깅밖에 없고, 엑시오스 에러일때 로깅은 try-catch문에서도 충분하 하고 있으니까요
Comment on lines
+8
to
+15
| (config) => { | ||
| const token = localStorage.getItem("token"); | ||
|
|
||
| if (token && !config.url?.includes("/auth/signIn")) { | ||
| config.headers.Authorization = `Bearer ${token}`; | ||
| } | ||
|
|
||
| return config; |
Comment on lines
+19
to
+27
| setAddImage(URL.createObjectURL(file)); | ||
|
|
||
| try { | ||
| const imgUrl = await postArticlesImage(file); | ||
| setImage(imgUrl); | ||
| console.log(imgUrl); | ||
| } catch (err) { | ||
| console.error("Error Messages: " + err); | ||
| } |
There was a problem hiding this comment.
이 부분 로직이 조금 햇갈리는데 , 19번 라인에서 미리보기 URL을 만들고, 22번 라인에서 파일을 올려서 파일 URL(, image URL )을 가져오네용. 그럼 addImage와 setImage로 설정한 이미지 url이 같은 이미지에 대해서 가르키는 걸까요?
만약 그렇다면 이미지 업로드 전에는 addImage로 이미지를 보여주고 이미지 업로드 후에는 imgUrl 하나만으로 해야 할 것 같아요.
Comment on lines
+44
to
+46
| try { | ||
| const data = await postLogin(); | ||
| return data; |
There was a problem hiding this comment.
어디로 리턴하는거죠 !?!? 리턴 후 사용하고 있지 않은거 같습니다 !!
| likeCount: number; | ||
| createdAt: string; | ||
| updatedAt: string; | ||
| writer: Writer; | ||
| }; | ||
|
|
||
| export type ArticlesAdd = Pick<ArticlesList, "title" | "content" | "image">; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
회원가입
로그인
메인
주요 변경사항
스크린샷
멘토에게
(intercepters를 사용했을때 기존코드 보다 어떤 장점이 있는지 아직은 확 느껴지지는 않는것 같습니다.)