-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[강성구] Sprint2 #33
The head ref may contain hidden characters: "Basic-\uAC15\uC131\uAD6C"
[강성구] Sprint2 #33
Changes from all commits
d313288
101f8d4
5aff940
c445d67
04cc1fc
38a8132
1da6197
1cbc391
7d548bc
4f8b359
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,34 +7,34 @@ | |
<link rel="apple-touch-icon" sizes="180x180" href="source/icons/favicon/apple-touch-icon.png"> | ||
<link rel="icon" type="image/png" sizes="32x32" href="source/icons/favicon/favicon-32x32.png"> | ||
<link rel="icon" type="image/png" sizes="16x16" href="source/icons/favicon/favicon-16x16.png"> | ||
<link rel="stylesheet" href="style.css" /> | ||
<!-- <link rel="manifest" href="/site.webmanifest"> --> | ||
<link rel="stylesheet" href="index.css" /> | ||
|
||
</head> | ||
<body> | ||
<header> | ||
<section class="nav"> | ||
<nav class="nav"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. goood ~~! 더욱 시멘틱 태그스러워졌습니당 👍 |
||
<a href="/" class="logo"> | ||
<img class="logo-img" src="source/images/logo/logo.png" alt="판다마켓 로고"/> | ||
</a> | ||
<button class="btn login" onclick="location.href='login'">로그인</button> | ||
</section> | ||
<button class="btn login" onclick="goAnotherPage('login/login.html')">로그인</button> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 요건 react스럽군용 ㅋㅋㅋ |
||
</nav> | ||
</header> | ||
<section class="headline"> | ||
<div class="headline-content"> | ||
<div class="headline-title"> | ||
<div class="title">일상의 모든 물건을<br>거래해 보세요</div> | ||
<button class="btn headline-btn" onclick="location.href='/items'">구경하러 가기</button> | ||
<h3 class="title">일상의 모든 물건을<br>거래해 보세요</h3> | ||
<button class="btn headline-btn" onclick="goAnotherPage('items/')">구경하러 가기</button> | ||
</div> | ||
<img src="source/images/headline/Img_home_top.png" alt="headline image"> | ||
<img src="source/images/headline/Img_home_top.png" alt="headline image" width="50%"> | ||
</div> | ||
</section> | ||
<main> | ||
<section class="popular"> | ||
<div class="container"> | ||
<img class="info-img" src="source/images/main/section1/Img_home_01.png" alt="Hot Item Image"> | ||
<img class="info-img" src="source/images/main/section1/Img_home_01.png" alt="Hot Item Image" width="50%"> | ||
<div class="content"> | ||
<div class="category">Hot item</div> | ||
<div class="section-title popular-title">인기 상품을<br>확인해 보세요</div> | ||
<h3 class="section-title popular-title">인기 상품을<br>확인해 보세요</h3> | ||
<div class="section-description popular-description"> | ||
가장 HOT한 중고거래 물품을<br>판다 마켓에서 확인해 보세요 | ||
</div> | ||
|
@@ -43,10 +43,10 @@ | |
</section> | ||
<section class="search"> | ||
<div class="container"> | ||
<img class="info-img" src="source/images/main/section2/Img_home_02.png" alt="Search Image"> | ||
<img class="info-img" src="source/images/main/section2/Img_home_02.png" alt="Search Image" width="50%"> | ||
<div class="content"> | ||
<div class="category">Search</div> | ||
<div class="section-title search-title">구매를 원하는<br>상품을 검색하세요</div> | ||
<h3 class="section-title search-title">구매를 원하는<br>상품을 검색하세요</h3> | ||
<div class="section-description search-description"> | ||
구매하고 싶은 물품은 검색해서<br>쉽게 찾아보세요 | ||
</div> | ||
|
@@ -55,10 +55,10 @@ | |
</section> | ||
<section class="register"> | ||
<div class="container"> | ||
<img class="info-img" src="source/images/main/section3/Img_home_03.png" alt="Register Image"> | ||
<img class="info-img" src="source/images/main/section3/Img_home_03.png" alt="Register Image" width="50%"> | ||
<div class="content"> | ||
<div class="category">Register</div> | ||
<div class="section-title register-title">판매를 원하는<br>상품을 등록하세요</div> | ||
<h3 class="section-title register-title">판매를 원하는<br>상품을 등록하세요</h3> | ||
<div class="section-description register-description"> | ||
어떤 물건이든 판매하고 싶은 상품을<br>쉽게 등록하세요 | ||
</div> | ||
|
@@ -69,11 +69,11 @@ | |
<section class="footline"> | ||
<div class="footline-content"> | ||
<div class="footline-title"> | ||
<div class="title"> | ||
<h3 class="title"> | ||
믿을 수 있는<br>판다마켓 중고거래 | ||
</div> | ||
</h3> | ||
</div> | ||
<img src="source/images/footline/Img_home_bottom.png" alt="headline image"> | ||
<img src="source/images/footline/Img_home_bottom.png" alt="headline image" width="50%"> | ||
</div> | ||
</section> | ||
<footer> | ||
|
@@ -107,5 +107,6 @@ | |
</div> | ||
</section> | ||
</footer> | ||
<script src="index.js"></script> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
function goAnotherPage(src) { | ||
location.href = src; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서 내가 사용하기로 한 단위로 (rem 과 vw이라면 이 둘 중 하나로) 통일할 수는 없을 지 한번 더 고민해보세요!
padding 값이 직관적이지 않기 때문인데요!
만약 아무리 생각해도 저렇게 쓰는게 더 최선인 것 같다 라는 판단이 든다면 그땐 그냥 냅두세요😄
코드는 누가 뭐라든 본인만의 이유가 있다면 그게 정답입니다(아 물론 듣지 말란 소리는 아닙니다ㅎㅎ)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사실 css에 대한 내용을 깊게 다뤄본적 없는데,
멘토님 덕분에 조금 더 가독성 있는 코드와 요소 특성을 깊게 공부하는 것 같아 항상 감사드립니다 :)