[김현우] Sprint 10#71
Open
Accreditus wants to merge 3 commits intocodeit-sprint-fullstack:express-김현우from
Open
Conversation
ehj0128
reviewed
Oct 9, 2024
ehj0128
left a comment
There was a problem hiding this comment.
보통
-route
-controller
-service
이렇게 나누고 대부분의 로직이 service에 들어가게 되는데 service는 사용안하고 있는 것 같아서 추천드립니다.
| const { generateToken, generateRefreshToken } = require("../utils/jwt"); | ||
|
|
||
| exports.signUp = async (req, res) => { | ||
| const { email, password, nickname } = req.body; |
There was a problem hiding this comment.
password 는 암호화 전인가요? 그러면 클라이언트에서 보낼때도 그냥 password스트링 그대로 보내나요?
| }; | ||
|
|
||
| exports.refreshToken = async (req, res) => { | ||
| const { refreshToken } = req.body; |
There was a problem hiding this comment.
refreshToken 새로 발급할때 만료된 accessToken도 같이 받아오지는 않나요?
There was a problem hiding this comment.
auth middleware 에서 토큰검증을 한번 해서 상관 없으려나요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Weekly Mission for Backend Development
요구사항
기본
프론트엔드 구현 요구사항
중고마켓 페이지 (Secondhand Market Page)
상품 등록하기 페이지
백엔드 구현 요구사항
상품 등록
상품 상세
좋아요 기능
에러 처리
라우트 중복 제거
인증
상품 기능 인가
게시글 기능 인가
댓글 기능 인가
심화 요구사항
주요 변경사항
스크린샷
멘토에게 (To the Mentor)