박가연 sprint 3 과제 제출#48
Open
qlwlsmwoddl0813-wq wants to merge 1 commit intocodeit-sprint-fullstack:basicfrom
Hidden character warning
The head ref may contain hidden characters: "basic-\ubc15\uac00\uc5f0"
Open
박가연 sprint 3 과제 제출#48qlwlsmwoddl0813-wq wants to merge 1 commit intocodeit-sprint-fullstack:basicfrom
qlwlsmwoddl0813-wq wants to merge 1 commit intocodeit-sprint-fullstack:basicfrom
Conversation
wseungjin
approved these changes
Dec 29, 2025
| return response.data; | ||
| }) | ||
| .catch(function (error) { | ||
| console.log("목록 조회 중 에러 발생: " + error.message); |
Collaborator
There was a problem hiding this comment.
파일로 로깅하거나, 네트워크로 로깅을하거나, 디비로 로깅을 하면 좋을거 같아요. 지금은 말고 나중에 한번 해보시면 좋을거 같아요.
| }); | ||
| } | ||
|
|
||
| export function createArticle(data) { |
Collaborator
There was a problem hiding this comment.
createArticle 데이터 검증 validation을 하면 좋을거같아요.
| }); | ||
| } | ||
|
|
||
| export function patchArticle(id, updateData) { |
Collaborator
There was a problem hiding this comment.
patchArticle 데이터 검증 validation을 하면 좋을거같아요. (2)
|
|
||
| export async function createProduct(item) { | ||
| try { | ||
| const response = await axios.post(PRODUCT_URL, { |
Collaborator
There was a problem hiding this comment.
validation을 할때 400 Bad Request를 잘 활용해보시면 좋겠습니다.
| } from "./ProductService.js"; | ||
|
|
||
| async function main() { | ||
| console.log("--- 테스트를 시작합니다 ---"); |
Collaborator
There was a problem hiding this comment.
test코드 jest, mocha 를 사용해서 실제로 테스트 코드를 짜보고 돌려봐도 좋을거 같아요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.