[안예진]sprint5 미션 제출#69
Open
yyejin00 wants to merge 13 commits intocodeit-sprint-fullstack:react-안예진from
Hidden character warning
The head ref may contain hidden characters: "react-\uc548\uc608\uc9c4-sprint5"
Open
Conversation
yyejin00
added
매운맛🔥
yyejin00
added
최종제출
wseungjin
reviewed
Jan 20, 2026
| }, | ||
| }, | ||
| rules: { | ||
| 'no-unused-vars': ['error', { varsIgnorePattern: '^[A-Z_]' }], |
Collaborator
There was a problem hiding this comment.
eslint + prettier= biome
| if (newData.image !== originalData.image) { | ||
| patchData.image = newData.image; | ||
| } | ||
| return patchData; |
Collaborator
There was a problem hiding this comment.
{ title : newData.title !== originalData.title ? newData.title : undefined
content
}
| const name = formData.get('name'); | ||
| const description = formData.get('description'); | ||
| const price = Number(formData.get('price')); | ||
| const tags = formData.get('tags').split(','); |
wseungjin
reviewed
Jan 20, 2026
| console.log(data); | ||
| return data; | ||
| } catch (error) { | ||
| console.log(`[product get] - 에러발생${error.message}`); |
Collaborator
There was a problem hiding this comment.
유의미하진 않은거같아요.
개발용으로는 괜찮아요.
다른 사람이면 근데 알수가 없어서 로깅을 확장하면 좋겠습니다.
| <a href="/pages/faq.html">FAQ</a> | ||
| </div> | ||
| <div className={styles.social}> | ||
| <div target="_blank" href="https://facebook.com"> |
| <div className={styles.content_text}> | ||
| <span className={styles.highlight}>hot item</span> | ||
| <div className={styles.title}> | ||
| 인기 상품을 |
| } | ||
| }; | ||
| getProducts(); | ||
| }, [currentPage, orderBy, pageSize]); |
| orderBy, | ||
| }); | ||
| setItems(list); // 첫렌더링이라서 아규먼트로 콜백함수를 사용할 필요없음. | ||
| setTotalCount(totalCount); |
| onPageChange, | ||
| }) => { | ||
| const totalPages = Math.ceil(totalCount / pageSize); | ||
| if (totalPages <= 1) return null; |
Collaborator
There was a problem hiding this comment.
react invalid hook call 이슈 공부
|
|
||
| const half = Math.floor(PAGE_WINDOW / 2); | ||
|
|
||
| let startPage = currentPage - half; |
| startPage = Math.max(totalPages - PAGE_WINDOW + 1, 1); | ||
| } | ||
|
|
||
| const pages = []; |
Collaborator
There was a problem hiding this comment.
[]; 생성하면 렌더링되면서 계속 생성할 수 있어요.
array랑 object는 생성한다고 값이 아니고 주소에 가까워요.
cosnt a = [2]
const b = [2]
a === b ?
프리미티브 값 vs array,object 대해서 공부를 해보면 좋을거 같습니다.
| } | ||
|
|
||
| const pages = []; | ||
| for (let i = startPage; i <= endPage; i++) { |
Collaborator
There was a problem hiding this comment.
map, foreach, reduce만 사용해주세요.
실수할 가능성이 높거든요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
프론트엔드 구현 요구사항
랜딩 페이지
중고마켓 페이지
상품 등록 페이지
심화 요구사항
프론트엔드 구현 요구사항
상품 등록 페이지
유효한 조건
상품명: 1자 이상, 10자 이내
상품 소개: 10자 이상, 100자 이내
판매 가격: 1자 이상, 숫자
태그: 5글자 이내)
멘토님께 질문있습니다!
페이지네이션이랑 심화 요구사항 하다보니까 오늘 프런트 ui를 못챙겼습니다. 이번에 hook이랑 util 나눠서 작성해봤습니다. 이렇게 작성하는 게 맞는지 멘토님께 피드백 받고 싶습니다. 감사합니다!
멘토님 혹시 이번 PR merge 해주실 수 있을까요?