Sprint 5 프론트엔드 제출#71
Open
JoohyoungJun wants to merge 11 commits intocodeit-sprint-fullstack:react-전주형from
Hidden character warning
The head ref may contain hidden characters: "react-\uc804\uc8fc\ud615sprint5"
Open
Sprint 5 프론트엔드 제출#71JoohyoungJun wants to merge 11 commits intocodeit-sprint-fullstack:react-전주형from
JoohyoungJun wants to merge 11 commits intocodeit-sprint-fullstack:react-전주형from
Conversation
11t518s
approved these changes
Jan 18, 2026
Collaborator
There was a problem hiding this comment.
요 .vite/deps 는 pr 에 안올라와도 됐었을 것 같습니다!
ignore에 들어가면 좋았을 것 같아서 다음에는 잘 확인해주시면 감사하겠습니다.
Collaborator
There was a problem hiding this comment.
이 backend 쪽 전체도 fe 코드랑은 관련이 없으니 다음에는 제외해주시면 좋을 것 같습니다
pr을 올린다는 것은 의도가 있는 변경사항을 리뷰받기 위해 올려주시는 건데, 이건 의도 없이 올라온 것 같습니다
지금은 멘토링이라 큰 문제 없지만 미래에 실제 협업하는 분들과 pr 을 주고받을 때는 이렇게 불필요한 파일이 생기기 시작하면 의도파악하기 어려울 수 있어서 딱 알맞은 변경사항만 포합해주시면 좋습니다!
Comment on lines
+7
to
+13
| let startPage; | ||
|
|
||
| if (totalPageNum <= maxVisiblePages) { | ||
| startPage = 1; | ||
| } else { // totalPageNum > 5 | ||
| startPage = Math.max(activePageNum - Math.floor(maxVisiblePages / 2), 1); | ||
| startPage = Math.min(startPage, totalPageNum - maxVisiblePages + 1); |
Collaborator
There was a problem hiding this comment.
react component 에서는 let으로 내부에 변수 선언해주는것이 좋은 패턴은 아닙니다!
- 왜 그럴까요?
- 그러면 이렇게 mutable 한 변수는 어떻게 관리할 까요!
요거 한번 답변 해주시면 감사하곘습니당
Comment on lines
+24
to
+32
| const isValid = | ||
| product.name.trim().length > 0 && | ||
| product.name.trim().length < 10 && | ||
| product.description.trim().length >= 10 && | ||
| !isNaN(Number(product.price)) && | ||
| Number(product.price) > 0 && | ||
| product.tags.trim().length > 0 && | ||
| product.tags.trim().length <= 5; | ||
|
|
Collaborator
There was a problem hiding this comment.
isValude가 좀 복잡해서 이거는 함수로 만들거나 하면 좋을 것 같아요!
함수로 해두고, 개별 validation 로직을 넣어보면 좋을 것 같습니다!
Collaborator
|
이거 그리고 conflict나는데 이것도 잡아서 말씀해주세요! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.