[김태영] sprint11#42
Open
csbizz wants to merge 4 commits intocodeit-sprint-fullstack:express-김태영from
Hidden character warning
The head ref may contain hidden characters: "express-\uae40\ud0dc\uc601-sprint11"
Open
Conversation
MCprotein
reviewed
Dec 17, 2024
|
|
||
| const upload = multer({ dest: 'uploads/' }); | ||
|
|
||
| export default function setupMiddlewares(app: express.Application) { |
There was a problem hiding this comment.
@csbizz
이거 middleware보다는 다른이름이 좋을거같아요
앱을 초기화하는 작업이라서 미들웨어랑 의미가 안맞아요
|
중급프로젝트때 타입스크립트로 하셔서 그런지 딱히 고칠만한 부분은 없네요 |
|
IoC, DI, layred architecture, singleton, 추상화, 상속 등 언어와 프레임워크에 종속되지 않은 개념들을 모든 기수 통틀어서 가장 잘 사용하신것같습니다 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
공통
백엔드
심화
주요 변경사항
스크린샷
멘토에게