[천우승] Sprint10#185
Open
mingmungXD wants to merge 1 commit intocodeit-sprint-fullstack:next-천우승from
Hidden character warning
The head ref may contain hidden characters: "next-\ucc9c\uc6b0\uc2b9-Sprint10"
Open
Conversation
prravda
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
모범답안을 참고하여 구현해주셨군요.
저도 모범답안을 확인해 봤는데 라이브러리들의 사용(react-hook-form, styled-component, tanstack-query 등)도 좋지만 전반적인 코드의 구조를 중점적으로 확인해보시는 걸 추천드립니다.
그 외에도 세부적으로 잘 구현이 되어있더군요. IME 를 통해 입력하는 과정에서의 isCompsing 활용과 같은 부분이나, AuthContext 의 구현, axios instance 에서의 처리 등도 봐 보시는 걸 추천드립니다.
프로젝트 파이팅입니다!
|
conflict 난 사항들 정리하시면 merge 처리 하도록 하겠습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게