[김단이] Sprint5#128
Open
danikim8 wants to merge 2 commits intocodeit-sprint-fullstack:react-김단이from
Hidden character warning
The head ref may contain hidden characters: "react-\uae40\ub2e8\uc774-sprint5"
Open
Conversation
dokdo2013
approved these changes
Mar 12, 2025
dokdo2013
left a comment
dokdo2013
left a comment
There was a problem hiding this comment.
- memo 폴더 올리신거 지우셔도 될 것 같습니다 ㅎㅎ
- 아직 스프린트 미션 파트는 구현 안 하신 걸로 이해했고, 이거는 다음 리뷰때라도 작업해서 올려주시면 리뷰해드리겠습니다!
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "axios": "^1.8.2", | ||
| "express": "^4.21.2", |
There was a problem hiding this comment.
오잉 express도 여기서 설치하셨네요? 미사용이면 지우셔도 될 듯 합니다.
Comment on lines
8
to
13
| <div className="nav"> | ||
| <Link to="/" className="homepage-logo-link"> | ||
| <img className="homepage-logo" src={logo} alt="판다마켓 로고" /> | ||
| </Link> | ||
| <Link className="homepage-login" to="/login">로그인</Link> | ||
| </div> |
There was a problem hiding this comment.
큰 이슈는 아니고, 이왕 nav로 className 지정하셨으니... div 태그 대신 nav 태그를 쓰는게 HTML 웹 접근성 측면에서 더 좋아보입니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏁 스프린트 미션 5 - 시안 확인
🔗 참고 링크
배포링크
스프린트 미션 5 Figma 디자인 확인
✅ 요구사항 체크리스트
기본 요구사항
공통
중고마켓 페이지
🔥 심화 요구사항
공통
중고마켓 페이지
중고 마켓의 카드 컴포넌트 반응형 기준은 다음과 같습니다.
베스트 상품
전체 상품
반응형에 따른 페이지 네이션 기능을 구현합니다.
🛠 주요 변경사항
📸 스크린샷
📝 멘토님에게 남길 메시지