Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test case for newlines #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tremby
Copy link

@tremby tremby commented Oct 4, 2018

There are two modes of failure here. The first added test string shows that indentation is not properly added after a newline. The second part, which is a new type of test, shows that the line following the
newline does not extend to the full length limit before it is broken again by this module. (It also shows the first issue, but not part of the existing test framework, so I thought maybe both are valuable.) To
illustrate:

Expected (there's a newline just before the capital B):

A a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a
    a a a a a a a a a a a
    B b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
    b b b b b b b b b b b

Actual:

A a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a
    a a a a a a a a a a a
B b b b b b b b b b b b b b b b b b b b b b b b b b b
    b b b b b b b b b b b b b b b b b b b b b b b b

There are two modes of failure here. The first added test string shows
that indentation is not properly added after a newline. The second
part, which is a new type of test, shows that the line following the
newline does not extend to the full length limit before it is broken
again by this module. (It also shows the first issue, but not part of
the existing test framework, so I thought maybe both are valuable.) To
illustrate:

Expected (there's a newline just before the capital B):

    A a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a
        a a a a a a a a a a a
        B b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b b
        b b b b b b b b b b b

Actual:

    A a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a
        a a a a a a a a a a a
    B b b b b b b b b b b b b b b b b b b b b b b b b b b
        b b b b b b b b b b b b b b b b b b b b b b b b
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7a62156 on tremby:newlines-test-case into 61043fb on codekirei:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7a62156 on tremby:newlines-test-case into 61043fb on codekirei:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants