fix #2797 Enhanced CrawlingConfigHelper with improved parameter namin…

…g and added extensive JUnit tests for robust testing
codelibs · Jan 11, 2024 · 296368a · 296368a
1 parent ed73caf
commit 296368a
Show file tree

Hide file tree

Showing 2 changed files with 442 additions and 4 deletions.
diff --git a/src/main/java/org/codelibs/fess/helper/CrawlingConfigHelper.java b/src/main/java/org/codelibs/fess/helper/CrawlingConfigHelper.java
@@ -151,12 +151,12 @@ public synchronized String store(final String sessionId, final CrawlingConfig cr
         return sessionCountId;
     }
 
-    public void remove(final String sessionId) {
-        crawlingConfigMap.remove(sessionId);
+    public void remove(final String sessionCountId) {
+        crawlingConfigMap.remove(sessionCountId);
     }
 
-    public CrawlingConfig get(final String sessionId) {
-        return crawlingConfigMap.get(sessionId);
+    public CrawlingConfig get(final String sessionCountId) {
+        return crawlingConfigMap.get(sessionCountId);
     }
 
     public List<WebConfig> getAllWebConfigList() {
@@ -277,6 +277,10 @@ public List<String> getExcludedUrlList(final String configId) {
     }
 
     public OptionalEntity<CrawlingConfig> getDefaultConfig(final ConfigType configType) {
+        if (configType == null) {
+            return OptionalEntity.empty();
+        }
+
         final String name = ComponentUtil.getFessConfig().getFormAdminDefaultTemplateName();
 
         return switch (configType) {