-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept directories #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airtonzanon
force-pushed
the
accept-directories
branch
3 times, most recently
from
August 27, 2019 13:01
2695097
to
8cbc7bf
Compare
vini-btc
reviewed
Aug 27, 2019
No tests? |
Signed-off-by: Airton Zanon <me@airton.dev>
airtonzanon
force-pushed
the
accept-directories
branch
from
August 27, 2019 14:34
8cbc7bf
to
dd0fbf4
Compare
Signed-off-by: Airton Zanon <me@airton.dev>
airtonzanon
force-pushed
the
accept-directories
branch
from
August 27, 2019 14:40
dd0fbf4
to
f81646f
Compare
Signed-off-by: Airton Zanon <me@airton.dev>
airtonzanon
force-pushed
the
accept-directories
branch
from
August 29, 2019 17:06
e85ac81
to
8a0c581
Compare
@vicnicius habemus tests |
vini-btc
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok! 👍
Signed-off-by: Airton Zanon <me@airton.dev>
airtonzanon
force-pushed
the
accept-directories
branch
from
August 29, 2019 20:12
8a0c581
to
575f800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.