Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set php required version to ~7.4 || ~8.0 #85

Merged
merged 4 commits into from
Jul 23, 2021
Merged

Set php required version to ~7.4 || ~8.0 #85

merged 4 commits into from
Jul 23, 2021

Conversation

EHER
Copy link
Contributor

@EHER EHER commented Jul 22, 2021

Fix #81

@EHER EHER requested review from Ocramius and malukenho July 22, 2021 23:27
@EHER EHER self-assigned this Jul 22, 2021
Copy link
Contributor

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay, but CI says otherwise

EHER added 3 commits July 23, 2021 02:04
Reviewed-by: Jefersson Nathan <malukenho.dev@gmail.com>
Reviewed-by: Ocramius <ocramius@gmail.com>
Signed-off-by: 💻 Eher <alexandre@eher.com.br>
…to ^0.1.0 || ^0.3.0 || ^0.4.0"

This reverts commit ab115d0.

Signed-off-by: 💻 Eher <alexandre@eher.com.br>
This reverts commit d619e97.

Signed-off-by: 💻 Eher <alexandre@eher.com.br>
Signed-off-by: 💻 Eher <alexandre@eher.com.br>
@EHER
Copy link
Contributor Author

EHER commented Jul 23, 2021

We will need some changes to support PHP 8.1. (Issue #86)

I'll check just the supported versions for now so we can have CI stable again.

@EHER EHER merged commit 2af2dd5 into 1.0.x Jul 23, 2021
@EHER EHER deleted the php-version branch July 23, 2021 00:25
@malukenho malukenho added this to the 1.0.0 milestone Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Xulieta declares itself compatible with PHP 9?
3 participants