-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple validator issue #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malukenho
force-pushed
the
fix-multiple-validator-issue
branch
2 times, most recently
from
February 25, 2022 11:20
e67787d
to
e84049b
Compare
Signed-off-by: Jefersson Nathan <malukenho.dev@gmail.com> Co-authored-by: 💻 Eher <alexandre@eher.com.br>
It also fixes an issue with multiple validator for the same language. It was only applying the first validator described in the .xulieta.xml config file, besides the language being supported by other validators. Signed-off-by: Jefersson Nathan <malukenho.dev@gmail.com> Co-authored-by: 💻 Eher <alexandre@eher.com.br>
Use the composer api instead. Signed-off-by: Jefersson Nathan <malukenho.dev@gmail.com> Co-authored-by: 💻 Eher <alexandre@eher.com.br>
malukenho
force-pushed
the
fix-multiple-validator-issue
branch
from
February 25, 2022 11:25
e84049b
to
64c05eb
Compare
EHER
approved these changes
Feb 25, 2022
|
malukenho
force-pushed
the
fix-multiple-validator-issue
branch
6 times, most recently
from
February 25, 2022 12:59
adccfc9
to
0ae4d40
Compare
Signed-off-by: Jefersson Nathan <malukenho.dev@gmail.com>
malukenho
force-pushed
the
fix-multiple-validator-issue
branch
from
February 25, 2022 13:01
0ae4d40
to
ee232a5
Compare
EHER
approved these changes
Feb 25, 2022
Dando aquela lida no código dos brabos pra ver se eu aprendo algo :p |
@danielhe4rt as parte mais divertidas de escrever na minha opinião:
Recomendo ver esses aspectos caso já não tenha experienciado. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.