Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple validator issue #96

Merged
merged 4 commits into from
Feb 25, 2022
Merged

Fix multiple validator issue #96

merged 4 commits into from
Feb 25, 2022

Conversation

malukenho
Copy link
Member

No description provided.

@malukenho malukenho added bug Something isn't working enhancement New feature or request labels Feb 25, 2022
@malukenho malukenho added this to the 1.0.0 milestone Feb 25, 2022
@malukenho malukenho self-assigned this Feb 25, 2022
@EHER EHER self-requested a review February 25, 2022 11:14
@malukenho malukenho force-pushed the fix-multiple-validator-issue branch 2 times, most recently from e67787d to e84049b Compare February 25, 2022 11:20
malukenho and others added 3 commits February 25, 2022 12:24
Signed-off-by: Jefersson Nathan <malukenho.dev@gmail.com>
Co-authored-by: 💻 Eher <alexandre@eher.com.br>
It also fixes an issue with multiple validator for the same language.
It was only applying the first validator described in the .xulieta.xml
config file, besides the language being supported by other validators.

Signed-off-by: Jefersson Nathan <malukenho.dev@gmail.com>
Co-authored-by: 💻 Eher <alexandre@eher.com.br>
Use the composer api instead.

Signed-off-by: Jefersson Nathan <malukenho.dev@gmail.com>
Co-authored-by: 💻 Eher <alexandre@eher.com.br>
@malukenho malukenho force-pushed the fix-multiple-validator-issue branch from e84049b to 64c05eb Compare February 25, 2022 11:25
@EHER
Copy link
Contributor

EHER commented Feb 25, 2022

Error: ] The minimum required MSI percentage should be 7%, but actual is 6.86%.

@malukenho malukenho force-pushed the fix-multiple-validator-issue branch 6 times, most recently from adccfc9 to 0ae4d40 Compare February 25, 2022 12:59
Signed-off-by: Jefersson Nathan <malukenho.dev@gmail.com>
@malukenho malukenho force-pushed the fix-multiple-validator-issue branch from 0ae4d40 to ee232a5 Compare February 25, 2022 13:01
@EHER EHER merged commit 1fd430c into 1.0.x Feb 25, 2022
@EHER EHER deleted the fix-multiple-validator-issue branch February 25, 2022 14:25
@danielhe4rt
Copy link

Dando aquela lida no código dos brabos pra ver se eu aprendo algo :p

@malukenho
Copy link
Member Author

@danielhe4rt as parte mais divertidas de escrever na minha opinião:

  • Plugins auto-configuráveis via composer req
  • Mutation tests
  • Psalm

Recomendo ver esses aspectos caso já não tenha experienciado. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants