-
Notifications
You must be signed in to change notification settings - Fork 26
Fix Issue 104: Tests are failing upon migration to codeanalyzer
v2.1.0+
#111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 104: Tests are failing upon migration to codeanalyzer
v2.1.0+
#111
Conversation
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
…a superclass if Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
codeanalyzer v2.1
codeanalyzer
v2.1.0+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: There were a number of folders and files related to mkdocs
that were removed as part of this PR (therefore the 146 files changed)
Signed-off-by: John Rofrano <johnnyroy@johnrofrano.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I increased the code coverage minimum in our Makefile
to 70% since we ave now surpassed that. Great work!
Motivation and Context
The failing test cases were caused by incorrect handling of
analysis.json
(which had changed since version 2.0.0 of codeanalyzer). Further, there were some nagging bugs on cyclicNotImplementedError
, issues with super classes inTreeSitter
etc.How Has This Been Tested?
The changes were tested by:
Breaking Changes
No breaking changes. The fixes ensure correctness without modifying existing API contracts or requiring configuration changes.
Types of changes
Checklist
Additional context
Fixed some bugs where treesitter fails to identify a superclass if
public class A extends B<C> { ... }