Skip to content

Commit

Permalink
Fix certificates globbing from relative paths for `keychain add-certi…
Browse files Browse the repository at this point in the history
…ficates` (#374)
  • Loading branch information
priitlatt authored Nov 13, 2023
1 parent 7f5f2c4 commit b68d8cb
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
Version 0.47.3
-------------

**Bugfixes**
- Fix handling of relative certificate path patterns for action `keychain add-certificates`. [PR #374](https://github.com/codemagic-ci-cd/cli-tools/pull/374)

Version 0.47.2
-------------

**Bugfixes**
- Fix actions `firebase-app-distribution get-latest-build-version` and `firebase-app-distribution releases list` for cases when specified application does not have any releases available. [PR #373](https://github.com/codemagic-ci-cd/cli-tools/pull/373)


Version 0.47.1
-------------

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "codemagic-cli-tools"
version = "0.47.2"
version = "0.47.3"
description = "CLI tools used in Codemagic builds"
readme = "README.md"
authors = [
Expand Down
2 changes: 1 addition & 1 deletion src/codemagic/__version__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
__title__ = "codemagic-cli-tools"
__description__ = "CLI tools used in Codemagic builds"
__version__ = "0.47.2.dev"
__version__ = "0.47.3.dev"
__url__ = "https://github.com/codemagic-ci-cd/cli-tools"
__licence__ = "GNU General Public License v3.0"
2 changes: 1 addition & 1 deletion src/codemagic/tools/keychain.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ def add_certificates(
add_for_apps = list(self._get_certificate_allowed_applications(allowed_applications))

self.logger.info("Add certificates to keychain %s", self.path)
certificate_paths = list(self.find_paths(*certificate_path_patterns))
certificate_paths = list(self.find_paths(*(p.resolve() for p in certificate_path_patterns)))
if not certificate_paths:
raise KeychainError("Did not find any certificates from specified locations")

Expand Down

0 comments on commit b68d8cb

Please sign in to comment.