Skip to content

Commit

Permalink
Merge branch 'master' of github.com:codemagic-ci-cd/cli-tools into bu…
Browse files Browse the repository at this point in the history
…gfix/apple-silicon-mac-device-class
  • Loading branch information
priitlatt committed Nov 7, 2024
2 parents fc70e5d + 369bc51 commit fab2819
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ Version 0.54.3
**Bugfixes**
- Support device class `APPLE_SILICON_MAC` on App Store Connect API [`Device`](https://developer.apple.com/documentation/appstoreconnectapi/device) responses. [PR #437](https://github.com/codemagic-ci-cd/cli-tools/pull/437)

**Improvements**
- Fail action `app-store-connect fetch-signing-files` early with descriptive error message if bundle ID identifier is not given. [PR #438](https://github.com/codemagic-ci-cd/cli-tools/pull/438)

Version 0.54.2
-------------

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ def fetch_signing_files(
for Bundle ID with given identifier
"""

if not bundle_id_identifier:
raise BundleIdArgument.BUNDLE_ID_IDENTIFIER.raise_argument_error(
'Bundle ID identifier must be specified, empty values are not allowed. For example "com.example.app".',
)

private_key = self._get_certificate_key(certificate_key, certificate_key_password)
if private_key is None:
raise AppStoreConnectError(f"Cannot save {SigningCertificate.s} without certificate private key")
Expand Down

0 comments on commit fab2819

Please sign in to comment.