Support command execution on Windows #156
Merged
+141
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases the tools provided by this module are actually just more user-friendy wrappers for some other executables in the system. As such, much of the heavylifting is done by the
CliProcess
class, which unfortunately currently does not work on Windows:The exception above is caused because reading executed command
stderr
andstdout
was implemented for Unix file descriptors only, which rely onfcntl
. However on Windows the command streams have Win32 named pipes in the background.To overcome this, an abstraction layer was added in the form of
CliProcessStream
, which takes care of platform specific code for unblocking the streams and reading from them.