Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter resource enum class name for argument parsing error messages #170

Merged
merged 4 commits into from
Dec 17, 2021

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Nov 24, 2021

In case invalid value is passed to CLI argument which maps to enumeration, then the error message which is displayed to users does not look pretty as it contains the literal class name of the enumeration such as

$ app-store-connect builds submit-to-app-store --release-type 'invalid release type'
...
app-store-connect builds submit-to-app-store: error: argument --release-type: invalid ReleaseType value: 'invalid release type'

With the changes introduced here, the error above will look like

app-store-connect builds submit-to-app-store: error: argument --release-type: invalid release type value: 'invalid release type'

@priitlatt priitlatt marked this pull request as ready for review December 17, 2021 09:47
@priitlatt priitlatt merged commit e39d385 into master Dec 17, 2021
@priitlatt priitlatt deleted the feature/invalid-resource-enum-error-messages branch December 17, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants