-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Cache generated App Store Connect JSON web tokens to disk #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9bd3240.
Fixes #176 . |
artemii-yanushevskyi
approved these changes
Dec 27, 2021
priitlatt
added a commit
that referenced
this pull request
Dec 28, 2021
* Add option to retry unauthorized App Store Connect requests (#178) * Docs: Update `app-store-connect` docs with `--api-unauthorized-retries` option (#179) * Feature: Improve argparse error messages for typed CLI args (#180) * Feature: Cache generated App Store Connect JSON web tokens to disk (#181) * Docs: Update `app-store-connect` docs with `--disable-jwt-cache` option (#183)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes App Store Connect API yields false positive results with regards to authentication. More precisely, requests signed with JSON web tokens that are generated from completely valid API keys can result in a response with status code 401 and content
To reduce the chance of this to happen, one way it to add a graceful retry logic (as is done in #178). Another way is to use JSON Web Tokens that are known to work as many times as possible. The changes in this pull request implement the latter approach.
By default App Store Connect API requests initiated by
app-store-connect
actions try to load JSON Web Token from a file cache instead of generating new token for each individual command invocation. This can be turned off by specifying--disable-jwt-cache
option.Affected actions:
Examples
Docs related to the changes made here are in a separate PR #183.