Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: xcode-project use-profiles logs for set code signing settings #203

Merged
merged 7 commits into from
Feb 22, 2022

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Feb 21, 2022

Sometimes building Xcode projects with xcode-project build-ipa fail with errors such as

error: TargetName has conflicting provisioning settings. TargetName is automatically signed for development, but a conflicting code signing identity iPhone Distribution has been manually specified. Set the code signing identity value to "Apple Development" in the build settings editor, or switch to manual signing in the Signing & Capabilities editor. (in target 'TargetName' from project 'Runner')

even though before running the build, actionxcode-project use-profiles was called, and the code signing settings were seemingly successfully configured.

Usually the reason for this is that xcode-project use-profiles did not assign usable provisioning profile to the Xcode target TargetName, which is actually required for successful Xcode project build.

The aim of this PR is to make it clearer when such conflicting code signing settings happen. This is achieved by two steps.

First make it possible to further debug what settings were configured for each found Xcode project target by logging code_signign_manager.rb output always to debug log file. Also make it possible to include this output to xcode-project use-profiles output via new command line switch --code-signing-setup-verbose-logging without the need to enable fully verbose log output.

Second and perhaps more notable change for end users is that xcode-project use-profiles now shows warnings about targets for which code signing settings were not updated. The warning are based on targets for which code signing settings were set to avoid excess noise.

Updated logs

Screenshot 2022-02-21 at 15 33 59

Updated actions:

  • xcode-project use-profiles.

@priitlatt priitlatt changed the title Improvement: xcode project use profiles logs Improvement: xcode-project use-profiles logs for set code signing settings Feb 21, 2022
@priitlatt priitlatt added the enhancement New feature or request label Feb 21, 2022
@priitlatt priitlatt marked this pull request as ready for review February 21, 2022 14:43
Copy link
Contributor

@mikhail-tokarev mikhail-tokarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priitlatt priitlatt merged commit d4394f6 into master Feb 22, 2022
@priitlatt priitlatt deleted the improvement/xcode-project-use-profiles-logs branch February 22, 2022 08:02
@priitlatt priitlatt restored the improvement/xcode-project-use-profiles-logs branch February 23, 2022 12:06
@priitlatt priitlatt deleted the improvement/xcode-project-use-profiles-logs branch February 23, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants