Make certificates and private keys handling more convenient #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKCS#12 support in pyOpenSSL is deprecated and cryptography APIs should be used instead.
…rtificate_key argument
artemii-yanushevskyi
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this pull request is to make the Python API more user friendly for private key and certificate management. Additionally make
AppStoreConnectclass methods that implementapp-store-connectactions which manage certificate easier to use by allowing directly plugging inPrivateKeyinstances in stead of having to useTypes.CertificateKeyArgumenttype wrapper.Notable changes:
PrivateKeyto load the key from PKCS#12 containers.app-store-connecttool.DSAand elliptic curve private keys in addition toRSAkeys forPrivateKey.Updated actions:
app-store-connect create-certificate,app-store-connect get-certificate,app-store-connect list-certificates,app-store-connect fetch-signing-files.