Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Address issues in android-keystore tool #210

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Mar 17, 2022

This is a bugfix PR to address issues that slipped through with android-keystore tool release.

The issues were:

  • Action android-keystore create-debug-keysotre did not work since it called create method with invalid keyword argument.
  • Argument --keystore was not required for actions android-keystore create and android-keystore verify which potentially caused unexpected failures when invoking those actions.
  • When trying to verify non-keystore file as a keystore the shown error message contained Java classpaths and was misleading. The error is now more self-explanatory.

Affected actions:

  • android-keystore create,
  • android-keystore create-debug-keystore,
  • android-keystore verify.

@priitlatt priitlatt added the bug Something isn't working label Mar 18, 2022
@priitlatt priitlatt marked this pull request as ready for review March 18, 2022 08:56
@priitlatt priitlatt merged commit cf232aa into master Mar 18, 2022
@priitlatt priitlatt deleted the bugfix/android-keystore branch March 18, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant