Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add expiration_date and creation_date properties to ProvisioningProfile #211

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Mar 24, 2022

Update Python API for codemagic.models.ProvisioningProfile by adding new readonly properties

  • ProvisioningProfile.creation_date -> datetime.datetime and
  • ProvisioningProfile.expiration_date -> datetime.datetime.

This allows library consumers to check when the provisioning profile was created and when will it expire. Creation and expiration date values are in UTC and are obtained from the provisioning profile plist with via keys CreationDate and ExpirationDate respectively.

@priitlatt priitlatt marked this pull request as ready for review March 24, 2022 12:19
@priitlatt priitlatt added the enhancement New feature or request label Mar 24, 2022
@priitlatt priitlatt merged commit 3be80a5 into master Mar 24, 2022
@priitlatt priitlatt deleted the feature/profile-timestamps branch March 24, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant