Bugfix: Update Xcode project bundle identifier resolving #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace custom bundle identifier parsing logic with builtin method XCBuildConfiguration#resolve_build_setting method from xcodeproj gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action
xcode-project use-profilesis using Ruby scriptcode_signing_manager.rbunder the hood to make changes to Xcode project files.In there was bunch of custom made logic to retrieve bundle identifier value for Xcode project build configurations. This logic however fails to detect the bundle identifier in case build configuration inherits build settings from
xcconfigconfigurations in some cases.To make this component simpler and more robust, replace the custom code by Xcodeproj Ruby gem built-in method
XCBuildConfiguration#resolve_build_setting method.Updated actions
xcode-project use-profiles