Improvement: Include all eligible certificates when creating a profile #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature/include-all-certificates-when-creating-profile
…ature/include-all-certificates-when-creating-profile
priitlatt
deleted the
feature/include-all-certificates-when-creating-profile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action
app-store-connect fetch-signing filesis capable of creating missing signing files in case none are found for the specified criteria (requires--createflag to be present).When a suitable provisioning profile is not found and has to be created on the fly by this action, then this profile will include only the code signing certificate(s) that contain given certificate private key (defined by
--certificate-key). This is somewhat pointless limitation and significantly reduces the possible usages for created profile.Instead we can include all possible certificates that match profile's type from the App Store Connect team in the profile. This way the profile usage is not limited to just one specific code signing certificate.
Updated actions:
app-store-connect fetch-signing-files