Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Configure code signing for iOS UI testing targets #258

Merged
merged 6 commits into from
Sep 5, 2022

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Sep 5, 2022

When building iOS project for testing with xcodebuild build-for-testing while targeting real hardware it is required that UI testing targets are code signed. Otherwise the tests cannot be propery executed.

Without the changes in this PR xcode-project use-profiles did not configure code signing for Xcode build targets with product type com.apple.product-type.bundle.ui-testing. The modifications introduced here make sure that those targets are also assigned matching signing configuration, provided that suitable provisioning profiles exist.

Updated actions

  • xcode-project use-profiles

@priitlatt priitlatt marked this pull request as ready for review September 5, 2022 11:09
Copy link
Contributor

@VeArnold VeArnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
priitlatt and others added 2 commits September 5, 2022 16:08
Co-authored-by: VeArnold <56921374+VeArnold@users.noreply.github.com>
@priitlatt priitlatt merged commit 7ee61dc into master Sep 5, 2022
@priitlatt priitlatt deleted the bugfix/ui-testing-target-code-signing branch September 5, 2022 13:14
@priitlatt priitlatt added the bug Something isn't working label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants