Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: iOS unit tests signing configuration setup #261

Merged
merged 9 commits into from
Sep 13, 2022

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Sep 9, 2022

Fix configuring code signing settings with xcode-project use-profiles for iOS unit testing build targets.

It used to be that empty code signign settings were always assigned to Xcode build targets with product type com.apple.product-type.bundle.unit-test. This works as long as tests are launched on a simulator, but when a physical devices are targeted as test destination, then code signing becomes mandatory.

Unit testing targets do not take profiles, but require information about certificate which can be used for signing. Signing information is obtained eitther from

  • a provisioning provile that matches exactly the bundle identifier of test target build configuration,
  • if the former does not exist, reuse test target host application matching build configuration.

Updated actions

  • xcode-project use-profiles

@priitlatt priitlatt marked this pull request as ready for review September 12, 2022 13:44
Copy link
Contributor

@remarkov remarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@priitlatt priitlatt merged commit d8fb195 into master Sep 13, 2022
@priitlatt priitlatt deleted the bugfix/ios-unit-tests-signing-configuration branch September 13, 2022 08:32
@priitlatt priitlatt mentioned this pull request Sep 13, 2022
@priitlatt priitlatt added the bug Something isn't working label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants